Lavisys/mailsweep
2
0
Fork 0
Code Issues 2 Pull requests Projects Releases 7 Packages Wiki Activity Actions

[gmail-safety-and-standards-hardening] #02: Domain Model Immutability & Dedup Encapsulation #21

New issue
Closed
opened 2026-08-28 17:32:18 +03:00 by jalmari · 0 comments
jalmari commented 2026-08-28 17:32:18 +03:00
Owner
Copy link

Feature: gmail-safety-and-standards-hardening | Source: .scratch/gmail-safety-and-standards-hardening/issues/02-domain-model-immutability-and-dedup-encapsulation.md

02: Domain Model Immutability & Dedup Encapsulation

What to build: Refactor EmailHeader to restore immutability and provide clean domain methods for message identity and label merging (dedup_key, with_merged_labels), eliminating Feature Envy and Primitive Obsession in MailboxGateway.scan(). Centralize category mailbox prefixes into the rules registry.

Blocked by: None (can start immediately)

Status: completed

  • Add dedup_key domain property or method to EmailHeader replacing ad-hoc string formatting in gateway.py.
  • Add immutable with_merged_labels(new_labels) or clean domain method to EmailHeader instead of in-place tuple mutation in scan().
  • Move hardcoded category path prefixes (categories/, luokat/, etc.) from MailboxGateway into the rules/fixtures registry.
  • Ensure all existing and new gateway tests pass without regression.
**Feature**: `gmail-safety-and-standards-hardening` | **Source**: `.scratch/gmail-safety-and-standards-hardening/issues/02-domain-model-immutability-and-dedup-encapsulation.md` # 02: Domain Model Immutability & Dedup Encapsulation **What to build:** Refactor `EmailHeader` to restore immutability and provide clean domain methods for message identity and label merging (`dedup_key`, `with_merged_labels`), eliminating Feature Envy and Primitive Obsession in `MailboxGateway.scan()`. Centralize category mailbox prefixes into the rules registry. **Blocked by:** None (can start immediately) **Status:** completed - [x] Add `dedup_key` domain property or method to `EmailHeader` replacing ad-hoc string formatting in `gateway.py`. - [x] Add immutable `with_merged_labels(new_labels)` or clean domain method to `EmailHeader` instead of in-place tuple mutation in `scan()`. - [x] Move hardcoded category path prefixes (`categories/`, `luokat/`, etc.) from `MailboxGateway` into the rules/fixtures registry. - [x] Ensure all existing and new gateway tests pass without regression.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
develop
v0.1.6
v0.1.5
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
Labels
Clear labels   
completed
Resolved and completed

  
feature
Feature epic or workstream

  
needs-info
Waiting for information

  
needs-triage
Needs triage assessment

  
ready-for-agent
Ready for automated agent execution

  
ready-for-human
Requires human decision or execution

  
spec
Feature specification

  
wontfix
Will not fix

No labels
completed
feature
needs-info
needs-triage
ready-for-agent
ready-for-human
spec
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#22 [gmail-safety-and-standards-hardening] #03: All Mail Discovery & Fallback
Lavisys/mailsweep
#23 [gmail-safety-and-standards-hardening] #04: Documentation & CONTEXT Synchronization
Lavisys/mailsweep
Reference
Lavisys/mailsweep#21
No description provided.