[gmail-safety-and-standards-hardening] #06: Encapsulate Label Queries on Domain Model #25

New issue

Closed

opened 2026-08-28 17:32:19 +03:00 by jalmari · 1 comment

jalmari commented

2026-08-28 17:32:19 +03:00

Owner

Feature: gmail-safety-and-standards-hardening | Source: .scratch/gmail-safety-and-standards-hardening/issues/06-encapsulate-label-queries-on-emailheader.md

06: Encapsulate Label Queries on Domain Model

What to build: Add domain query properties and methods to EmailHeader (normalized_labels, has_label(), is_promotional, is_social), eliminating Primitive Obsession and Feature Envy in ClassificationEngine.classify(). Remove unrequested top-level export of DEFAULT_GMAIL_CATEGORY_PREFIXES.

Blocked by: None (can start immediately)

Status: ready-for-agent

Add normalized_labels property to EmailHeader.
Add has_label(label: str) -> bool, is_promotional -> bool, and is_social -> bool to EmailHeader.
Refactor ClassificationEngine.classify() in src/mailsweep/classifier.py to use domain methods instead of ad-hoc set comprehensions.
Remove DEFAULT_GMAIL_CATEGORY_PREFIXES from __all__ in src/mailsweep/__init__.py.
Add unit tests in test_mailsweep.py verifying label query methods and backwards-compatibility.

**Feature**: `gmail-safety-and-standards-hardening` | **Source**: `.scratch/gmail-safety-and-standards-hardening/issues/06-encapsulate-label-queries-on-emailheader.md` # 06: Encapsulate Label Queries on Domain Model **What to build:** Add domain query properties and methods to `EmailHeader` (`normalized_labels`, `has_label()`, `is_promotional`, `is_social`), eliminating Primitive Obsession and Feature Envy in `ClassificationEngine.classify()`. Remove unrequested top-level export of `DEFAULT_GMAIL_CATEGORY_PREFIXES`. **Blocked by:** None (can start immediately) **Status:** ready-for-agent - [ ] Add `normalized_labels` property to `EmailHeader`. - [ ] Add `has_label(label: str) -> bool`, `is_promotional -> bool`, and `is_social -> bool` to `EmailHeader`. - [ ] Refactor `ClassificationEngine.classify()` in `src/mailsweep/classifier.py` to use domain methods instead of ad-hoc set comprehensions. - [ ] Remove `DEFAULT_GMAIL_CATEGORY_PREFIXES` from `__all__` in `src/mailsweep/__init__.py`. - [ ] Add unit tests in `test_mailsweep.py` verifying label query methods and backwards-compatibility.

jalmari added the

ready-for-agent

feature

labels

2026-08-28 17:32:19 +03:00

jalmari added a new dependency

2026-08-28 17:32:32 +03:00

#22 [gmail-safety-and-standards-hardening] #03: All Mail Discovery & Fallback

jalmari added a new dependency

2026-08-28 17:32:32 +03:00

#23 [gmail-safety-and-standards-hardening] #04: Documentation & CONTEXT Synchronization

jalmari removed a dependency

2026-08-28 20:13:56 +03:00

#22 [gmail-safety-and-standards-hardening] #03: All Mail Discovery & Fallback

jalmari commented

2026-08-30 01:18:06 +03:00

Author

Owner

Implemented label query encapsulation on EmailHeader (normalized_labels, has_label(), is_promotional, is_social), refactored ClassificationEngine.classify() to eliminate primitive obsession, removed DEFAULT_GMAIL_CATEGORY_PREFIXES top-level export, and added unit tests in commit 3a13959.

Implemented label query encapsulation on `EmailHeader` (`normalized_labels`, `has_label()`, `is_promotional`, `is_social`), refactored `ClassificationEngine.classify()` to eliminate primitive obsession, removed `DEFAULT_GMAIL_CATEGORY_PREFIXES` top-level export, and added unit tests in commit `3a13959`.

jalmari closed this issue

2026-08-30 01:18:06 +03:00

jalmari referenced this issue from a commit

2026-08-30 01:18:38 +03:00

feat(classifier): encapsulate label queries on EmailHeader domain model (Closes #25)